This[1] should catch undefined preprocessor expressions, i.e. instead of
showing a warning if FOO_BAR_H is undefined:
#if FOO_BAR_H
make the build fail with an error instead.
This combined with using #cmakedefine01 (instead of #cmakedefine), could
catch things like:
https://invent.kde.org/pim/k
winterz closed this revision.
winterz added a comment.
see https://phabricator.kde.org/R240:db46fb7c2fdcfbff5f8a0445e4d055cf4388ead8
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #fr
winterz added a comment.
In https://phabricator.kde.org/D6762#126463, @nalvarez wrote:
> Looks reasonable – although I wonder why on earth you're building KDE stuff
on Cygwin...
fun. as an experiment. i'm curious.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #frameworks, #build_system
nalvarez added a comment.
Looks reasonable – although I wonder why on earth you're building KDE stuff
on Cygwin...
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows
Cc: nalvarez, #frameworks, #build_system
apol added a reviewer: Windows.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows
Cc: #frameworks, #build_system
winterz added reviewers: skelly, Build System.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system
Cc: #frameworks, #build_system
winterz created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Cygwin systems aren't ELF based so don't try to pass --enable-new-dtags to
'ld'
else you get
/usr/lib/gcc/x86_6
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0348332744d2: KDECompilerSettings: Pass -Wvla &
-Wdate-time (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5430?vs=13476&
kfunk updated this revision to Diff 13476.
kfunk added a comment.
Address mpyne's concerns
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5430?vs=13396&id=13476
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5430
AFFECTED FILE
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
I think these warning flags make sense as default warning flags. I don't
agree that `__DATE__` and `__TIME__` should be avoided as a rule, but projects
that find this valuable can disable th
kfunk added a comment.
For -Wdate-time:
https://lxr.kde.org/search?_filestring=&_string=__DATE__
https://lxr.kde.org/search?_filestring=&_string=__TIME__
-> Only around ~10 locations affected, mainly Krita/Digikam/Amarok stuff. The
use of __DATE__ & __TIME__ should just be avoided.
R
kfunk edited the summary of this revision.
kfunk edited the test plan for this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5430
To: kfunk
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
-Wvla: Warn because it's non-standard feature, not supported by MSVC to date
-Wdate-time: Warn because using __TIME
A quick warning: since the alpha is looming close, and we want these
changes to have the maximum testing possible, I'm going to commit the
various changes to KDECompilerSettings that I have queued up tomorrow.
This includes the changes currently on reviewboard, as well as a broad
reorganis
15 matches
Mail list logo
