Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-08 Thread René J . V . Bertin
So... It seems we are indeed looking at a Qt regression. https://github.com/RJVB/shortcut-test-qt5 That's an adapted version of Qt's menus example which adds a shortcut test action with a configurable shortcut string and commandline options to add it to the menubar and/or the context menu, pl

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-08 Thread René J . V . Bertin
On Sunday January 8 2017 11:48:08 Kevin Funk wrote: >Nope, sorry, never tried. Could you try with a current build when you have a moment, please? >I'm happy to receive any patches that improve shortcut handling in KDevelop on >Mac. Sure, but I think that in principle that should rather be patc

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-08 Thread Kevin Funk
On Saturday, 7 January 2017 23:45:11 CET René J.V. Bertin wrote: > On Saturday January 07 2017 13:32:22 René J.V. Bertin wrote: > > After saving the shortcuts to the current scheme and restarting the app: > > - the shortcut is shown as Command+< > > - it no longer works > > In fact, that was testi

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-07 Thread René J . V . Bertin
On Saturday January 07 2017 13:32:22 René J.V. Bertin wrote: > After saving the shortcuts to the current scheme and restarting the app: > - the shortcut is shown as Command+< > - it no longer works In fact, that was testing in KDevelop, which has a hardcoded Ctrl+< shortcut for the (popup menu)

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-07 Thread René J . V . Bertin
Looking over the kxmlgui code I notice isShiftAsModifierAllowed(), from KWindowSystem. Have there been recent changes in that function or its use in other places Applying the patch below has the following effect: - Command+Shift+, (Command+<) is shown as Command+Shift+, in the shortcut editor -

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-07 Thread René J . V . Bertin
On Saturday January 7 2017 19:33:13 Albert Astals Cid wrote: >You're a developer, you can reproduce the problem in one version and not in >another, instead of workarounding the problem you should bisect it until you >find where it broke. Sure, that's what I'd have done with my own code, and wha

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-07 Thread Albert Astals Cid
El divendres, 6 de gener de 2017, a les 21:29:13 CET, René J.V. Bertin va escriure: > On Friday January 06 2017 18:33:01 David Faure wrote: > > Well, you didn't say either way, so I tried to guess from your > > description, > > and guessed wrong. > > No problem, can't be right all the time (and i

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-06 Thread René J . V . Bertin
On Friday January 06 2017 18:33:01 David Faure wrote: > Well, you didn't say either way, so I tried to guess from your description, > and guessed wrong. No problem, can't be right all the time (and it's Friday night at that) ;) > > the shortcut shows up correctly (Command-<) but doesn't work. >