Re: Fix signal/Slot in kcmutils/dialog

2014-07-08 Thread David Faure
On Wednesday 09 July 2014 00:36:27 Aleix Pol wrote: > On Tuesday 08 July 2014 22:10:10 laurent Montel wrote: > > Hi, > > In qt4 it was a KDialog so okClicked() and applyClicked() existed. > > Now it’s a KPageDialog => a QDialog so we must to connect to > > QDialogButtonBox. > > > > This patch fixe

Re: Fix signal/Slot in kcmutils/dialog

2014-07-08 Thread Aleix Pol
On Tuesday 08 July 2014 22:10:10 laurent Montel wrote: > Hi, > In qt4 it was a KDialog so okClicked() and applyClicked() existed. > Now it’s a KPageDialog => a QDialog so we must to connect to > QDialogButtonBox. > > This patch fixes bad signal. > > Can I commit it ? > > Thanks Ship it! I'd sa

Fix signal/Slot in kcmutils/dialog

2014-07-08 Thread laurent Montel
Hi, In qt4 it was a KDialog so okClicked() and applyClicked() existed. Now it’s a KPageDialog => a QDialog so we must to connect to QDialogButtonBox. This patch fixes bad signal. Can I commit it ? Thanks -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (Franc