Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/#review48625 --- This review has been submitted with commit a8e9c0599a2787337b

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/ --- (Updated Jan. 30, 2014, 2:51 p.m.) Status -- This change has been ma

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Michael Palimaka
> On Jan. 30, 2014, 11:47 a.m., Alex Merry wrote: > > CMakeLists.txt, lines 52-55 > > > > > > Make this unconditional (ie: replace all four lines by just the > > find_package line) Will do, thanks. - Michael

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/#review48598 --- Ship it! Looks sensible. Just one thing while you're editing

Re: Review Request 115269: Improve dependency specifications

2014-01-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/#review48597 --- I would like to commit this soon if there are no comments. -

Review Request 115269: Improve dependency specifications

2014-01-23 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/ --- Review request for KDE Frameworks. Repository: kdnssd-framework Descrip

Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- (Updated Jan. 15, 2014, 12:13 p.m.) Status -- This change has been m

Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47437 --- This review has been submitted with commit 7e315ef53a9574ee17

Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47436 --- Ship it! Ship It! - David Faure On Jan. 15, 2014, 5:54 a.m

Re: Review Request 114961: Improve dependency specifications

2014-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114961/#review47423 --- This review has been submitted with commit 0e9590fdabf948f47c

Re: Review Request 114961: Improve dependency specifications

2014-01-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114961/ --- (Updated Jan. 15, 2014, 5:56 a.m.) Status -- This change has been ma

Re: Review Request 114962: Improve dependency specifications

2014-01-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- (Updated Jan. 15, 2014, 5:54 a.m.) Review request for KDE Frameworks. C

Re: Review Request 114962: Improve dependency specifications

2014-01-13 Thread Alex Merry
> On Jan. 11, 2014, 8:02 p.m., Alex Merry wrote: > > This should be using QT_REQUIRED_VERSION everywhere. Actually, if you > > could change it in the other CMakeLists.txt files, that would be good. > > Then it can be shipped. > > Michael Palimaka wrote: > No worries, will do. I only expl

Re: Review Request 114962: Improve dependency specifications

2014-01-12 Thread Michael Palimaka
> On Jan. 11, 2014, 8:02 p.m., Alex Merry wrote: > > This should be using QT_REQUIRED_VERSION everywhere. Actually, if you > > could change it in the other CMakeLists.txt files, that would be good. > > Then it can be shipped. No worries, will do. I only explicitly wrote the version for consi

Re: Review Request 114962: Improve dependency specifications

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47231 --- Ship it! This should be using QT_REQUIRED_VERSION everywhere.

Re: Review Request 114961: Improve dependency specifications

2014-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114961/#review47230 --- Ship it! Just one issue, then it can go in. autotests/CMake

Review Request 114962: Improve dependency specifications

2014-01-11 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- Review request for KDE Frameworks. Repository: kconfig Description

Review Request 114961: Improve dependency specifications

2014-01-10 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114961/ --- Review request for KDE Frameworks. Repository: solid Description --

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

2013-11-21 Thread Johannes Huber
marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Improve dependency specifications Depends only on Qt5 core for src. Move Qt test dependency spec to subdir. Diffs - tier3/kpty/CMakeLists.txt 12d977e tier3/kpty/autotests/CMakeLists.txt

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

2013-11-21 Thread Johannes Huber
. Repository: kdelibs Description --- Improve dependency specifications Depends only on Qt5 core for src. Move Qt test dependency spec to subdir. Diffs - tier3/kpty/CMakeLists.txt 12d977e tier3/kpty/autotests/CMakeLists.txt aa28cfc Diff: http://git.reviewboard.kde.org/r/113987

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

2013-11-21 Thread Commit Hook
t: > http://git.reviewboard.kde.org/r/113987/ > --- > > (Updated Nov. 21, 2013, 4:28 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > I

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

2013-11-21 Thread Kevin Ottens
v. 21, 2013, 4:28 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Improve dependency specifications > > Depends only on Qt5 core for src. Move Qt test dependency spec to > subdir. > >

Re: Dependency specifications

2013-09-15 Thread Alexander Neundorf
On Sunday 15 September 2013, Aleix Pol wrote: > On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly wrote: > > Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > > > > once > > > > > in the root CMakeLists.txt. Actually this should be the only file with > >

Re: Dependency specifications

2013-09-14 Thread Aleix Pol
On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly wrote: > Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > once > > in the root CMakeLists.txt. Actually this should be the only file with > > "find_package" calls. > > > > Why? What is the problem with ha

Re: Dependency specifications

2013-09-14 Thread Stephen Kelly
Aleix Pol wrote: > I'd say that all Qt dependencies in the module should be defined only once > in the root CMakeLists.txt. Actually this should be the only file with > "find_package" calls. > Why? What is the problem with having a find_package in src? Thanks, Steve.

Re: Dependency specifications

2013-09-14 Thread Michael Palimaka
On 12/09/2013 10:32, Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with "find_package" calls. At a high level, that sounds reasonable, but I don't think this is necessarily the best so

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:17:47 Aleix Pol wrote: > Well, but in that case you'll maybe want to find QtGui, QtWidgets or > KF5::AwesomeTests. Ah yes, true, manual tests can have more deps sometimes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Fra

Re: Dependency specifications

2013-09-13 Thread Aleix Pol
On Fri, Sep 13, 2013 at 1:17 PM, David Faure wrote: > On Friday 13 September 2013 13:03:29 Aleix Pol wrote: > > On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > > > I'd say that all Qt dependencies in the module should be defin

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:03:29 Aleix Pol wrote: > On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > > > > once > > > > > in the root CMakeLists.txt. A

Re: Dependency specifications

2013-09-13 Thread Aleix Pol
On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > I'd say that all Qt dependencies in the module should be defined only > once > > in the root CMakeLists.txt. Actually this should be the only file with > > "find_package" calls. > > A

Re: Dependency specifications

2013-09-13 Thread David Faure
On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > I'd say that all Qt dependencies in the module should be defined only once > in the root CMakeLists.txt. Actually this should be the only file with > "find_package" calls. And I disagree. If you build the framework with unittests disabled (

Re: Dependency specifications

2013-09-11 Thread Aleix Pol
On Tue, Sep 10, 2013 at 7:42 PM, Michael Palimaka wrote: > Hi, > > Currently, the specification for Qt dependencies is not always consistent > between tier1 frameworks. > > In particular, I notice dependencies being specified twice (eg. QtTest in > both project root and in autotests), and test dep

Dependency specifications

2013-09-11 Thread Michael Palimaka
Hi, Currently, the specification for Qt dependencies is not always consistent between tier1 frameworks. In particular, I notice dependencies being specified twice (eg. QtTest in both project root and in autotests), and test dependencies split (eg. QtTest in project root only, and QtXml in au