Re: Review Request 116876: Add default emoticons theme to kemoticons

2014-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/#review54049 --- This review has been submitted with commit 17f7505d56d13e89a7

Re: Review Request 116876: Add default emoticons theme to kemoticons

2014-03-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/ --- (Updated March 24, 2014, 11:50 p.m.) Status -- This change has been

Re: Review Request 116876: Add default emoticons theme to kemoticons

2014-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/#review54048 --- This review has been submitted with commit 9c2397e2666a2fd058

Re: Review Request 116876: Add default emoticons theme to kemoticons

2014-03-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/#review54006 --- Ship it! Ship It! - Kevin Ottens On March 18, 2014, 3:58 p

Review Request 116876: Add default emoticons theme to kemoticons

2014-03-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116876/ --- Review request for KDE Frameworks. Repository: kemoticons Description -

Re: Default emoticons theme

2014-03-18 Thread Aleix Pol
On Tue, Mar 18, 2014 at 3:13 PM, Alex Merry wrote: > On 17/03/14 11:57, Alex Merry wrote: > > On 15/03/14 19:04, Aleix Pol wrote: > >> I do agree that having an emoticons set together with kemoticons can be > >> very helpful and simplify the usage of the module. Also, it doesn't > >> really make

Re: Default emoticons theme

2014-03-18 Thread Alex Merry
On 17/03/14 11:57, Alex Merry wrote: > On 15/03/14 19:04, Aleix Pol wrote: >> I do agree that having an emoticons set together with kemoticons can be >> very helpful and simplify the usage of the module. Also, it doesn't >> really make sense to use kf5 or kde4. It's not something linked to the >> l

Re: Default emoticons theme

2014-03-17 Thread Alex Merry
On 15/03/14 19:04, Aleix Pol wrote: > I do agree that having an emoticons set together with kemoticons can be > very helpful and simplify the usage of the module. Also, it doesn't > really make sense to use kf5 or kde4. It's not something linked to the > library version, so it can be a theme name.

Re: Default emoticons theme

2014-03-15 Thread Aleix Pol
On Sat, Mar 15, 2014 at 3:14 PM, Kevin Ottens wrote: > Hello, > > On Saturday 15 March 2014 11:30:22 Alex Merry wrote: > > - it moves to kemoticons (where it will be guaranteed to be installed), > > retains its current name, and kemoticons selects "kf5" by default. > > It has my preference, so th

Re: Default emoticons theme

2014-03-15 Thread Kevin Ottens
Hello, On Saturday 15 March 2014 11:30:22 Alex Merry wrote: > - it moves to kemoticons (where it will be guaranteed to be installed), > retains its current name, and kemoticons selects "kf5" by default. It has my preference, so that you don't need an "obscure" (from 3rd party devs POV) dependenc

Default emoticons theme

2014-03-15 Thread Alex Merry
Currently, kde-runtime installs an emoticons theme called "kf5", and the kemoticons framework looks for a theme called "kde4" by default. I suggest that either: - the kde-runtime theme moves to the Oxygen repo, gets renamed to "oxygen", and kemoticons selects this by default, or - it moves to ke