D9823: Optimize: use QMetaObject::invokeMethod with functor

This revision was automatically updated to reflect the committed changes. Closed by commit R244:16e8cf1e6607: Optimize: use QMetaObject::invokeMethod with functor (authored by mwolff). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9823?vs=25366&id=25584

D9823: Optimize: use QMetaObject::invokeMethod with functor

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol, mpyne Cc: mpyne, #frameworks

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff updated this revision to Diff 25366. mwolff added a comment. thanks dfaure ;-) REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9823?vs=25172&id=25366 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9823 AFFECTED FILES src/lib/i

D9823: Optimize: use QMetaObject::invokeMethod with functor

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirwatch.cpp:1405 > +#else > +QMetaObject::invokeMethod(c.instance, [c, path]() { > c.instance->setDeleted(path); }, Qt::QueuedConnection) > +#en

D9823: Optimize: use QMetaObject::invokeMethod with functor

mpyne accepted this revision. mpyne added a comment. LGTM REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol, mpyne Cc: mpyne, #frameworks

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff added a comment. https://codereview.qt-project.org/#/c/216497/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D9823: Optimize: use QMetaObject::invokeMethod with functor

apol added a comment. In https://phabricator.kde.org/D9823#189491, @mwolff wrote: > cleaner, yes. but also much slower. contrary to the other code-paths, the `QTimer::singleShot` taking a functor is not optimized (yet?) for `timeout == 0`... Oh well... `¯\_(ツ)_/¯` REPOSITORY R

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff added a comment. cleaner, yes. but also much slower. contrary to the other code-paths, the `QTimer::singleShot` taking a functor is not optimized (yet?) for `timeout == 0`...F5638638: Screenshot_20180111_170829.png REPOSITORY R244 KCoreAddons

D9823: Optimize: use QMetaObject::invokeMethod with functor

apol added a comment. Maybe it would be cleaner to do `QTimer::singleShot(0, c.instance, lambda)`. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff updated this revision to Diff 25172. mwolff added a comment. This revision is now accepted and ready to land. make compile against older Qt REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9823?vs=25170&id=25172 REVISION DETAIL https://phabricat

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff planned changes to this revision. mwolff added a comment. requires 5.10, so I can't commit this as-is... REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D9823: Optimize: use QMetaObject::invokeMethod with functor

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY When using this method with a string argument, the method would nee