D9454: Remove impossible to reach code

2017-12-21 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R303:f68d54697318: Remove impossible to reach code (authored by vkrause). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9454?vs=24249&id=24250 REVISION DETAIL https://

D9454: Remove impossible to reach code

2017-12-21 Thread David Faure
dfaure accepted this revision. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D9454 To: vkrause, dfaure Cc: #frameworks

D9454: Remove impossible to reach code

2017-12-21 Thread Volker Krause
vkrause updated this revision to Diff 24249. vkrause added a comment. address review comment REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9454?vs=24226&id=24249 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9454 AFFECTED FILES src/kdei

D9454: Remove impossible to reach code

2017-12-21 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > wrapper.cpp:49 > { > // Can't use QGuiApplication::platformName() here, there is no app > instance. > return "DISPLAY"; Move this comment above the #if (of

D9454: Remove impossible to reach code

2017-12-21 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This also brings this back in sync with src/kdeinit/kinit.cpp. REPOSITORY R303 KInit BRANCH master R