This revision was automatically updated to reflect the committed changes.
Closed by commit R286:b680861aa2ed: extractors: Hide warnings from system
headers (authored by kfunk).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9408?vs=33189&id=33191
REVISI
mgallien accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9408
To: kfunk, mgallien
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns
kfunk updated this revision to Diff 33189.
kfunk added a comment.
Add PRIVATE
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9408?vs=33121&id=33189
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9408
AFFECTED FILES
src/extractors/
mgallien requested changes to this revision.
mgallien added a comment.
This revision now requires changes to proceed.
Please have a look at the issue.
Thanks
INLINE COMMENTS
> CMakeLists.txt:35
> +target_include_directories(kfilemetadata_exiv2extractor SYSTEM PRIVATE
> ${EXIV2_INCLUDE_
kfunk added a reviewer: mgallien.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D9408
To: kfunk, mgallien
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns
kfunk updated this revision to Diff 33121.
kfunk added a comment.
Restricted Application added a project: Baloo.
Rebased
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9408?vs=24101&id=33121
BRANCH
master
REVISION DETAIL
https://phabricator.kde.
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Also prefer kde_target_enable_exceptions() over the function enabling
exceptions globally.
REPOSITORY
R286 KFileMetaData
BRANCH
master
