D9393: MessageInterface: Add CenterInView as additional position

2017-12-18 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:fc7433321d36: MessageInterface: Add CenterInView as additional position (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9393?vs=24059&id=24061#toc REPOSITORY R39 KTextE

D9393: MessageInterface: Add CenterInView as additional position

2017-12-18 Thread Christoph Cullmann
cullmann added a comment. Jup, ok ;) The 5 as size is still bit strange, but as we have no end enum value, which we don't want to be BC, I guess that is no issue. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9393 To: dhaumann, cullmann Cc: #frameworks, ke

D9393: MessageInterface: Add CenterInView as additional position

2017-12-18 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH MessageInterface (branched from master) REVISION DETAIL https://phabricator.kde.org/D9393 To: dhaumann, cullmann Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, s

D9393: MessageInterface: Add CenterInView as additional position

2017-12-18 Thread Dominik Haumann
dhaumann updated this revision to Diff 24059. dhaumann added a comment. - Add @since 5.42 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9393?vs=24058&id=24059 BRANCH MessageInterface (branched from master) REVISION DETAIL https://phabricator.kde.o

D9393: MessageInterface: Add CenterInView as additional position

2017-12-18 Thread Dominik Haumann
dhaumann added a comment. @cullmann This patch now only adds the CenterInView, nothing else (i.e. no changes in search code). Now good to go? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9393 To: dhaumann, cullmann Cc: #frameworks, kevinapavew, ngraham, demski

D9393: MessageInterface: Add CenterInView as additional position

2017-12-18 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch extends the message interface to support CenterInView. This should be binary compatib