cullmann added a comment.
Hi, I appreciate the attention on the test, but as you see in
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/51/
they work again and the breakage was introduced (by me) in
https://phabricator.kde.org/D13394
Cross-module bre
bcooksley added a comment.
This change introduced changes which broke tests that previously passed.
Please see
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/48/testReport/(root)/TestSuite/
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c2580c5b0f22: Extend Scripting API (authored by dhaumann,
committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9219?vs=23543&id=37759
REVISION
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
;=)
Just missed that.
Why not ;)
REPOSITORY
R39 KTextEditor
BRANCH
Scripting (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9219
To: dhaumann, cullmann,
dhaumann added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel,
kwrite-devel; removed: Frameworks.
@cullmann ping? :-)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9219
To: dhaumann, cullmann, mwolff
Cc: kwrite-devel, kde-fram
dhaumann added a comment.
@cullmann Did you intentionally request changes or was that by accident and
you meant Accept?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9219
To: dhaumann, cullmann, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann,
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I think that extension idea is good.
The functions won't really fit to document or view and an editor object could
be used for other global things, too, without further pollu
dhaumann created this revision.
dhaumann added reviewers: cullmann, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the KTextEditor scripting API by:
- String editor.clipboardText()