This revision was automatically updated to reflect the committed changes.
Closed by commit R39:eb0bdd49417c: QStringList initializer list cleanup
(authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9205?vs=23518&id=23525
REVISION DETAIL
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
yep this is better than before after all
INLINE COMMENTS
> kateview.cpp:1385
>
> -QStringList l;
> -
> -l << QStringLiteral("edit_replace")
> - << QStringLiteral("tools_spell
dhaumann added a comment.
@mwolff I have a separate patch where I use STL algos in katedocument. I
would like to keep this as separate patch, though. So is this change fine now?
make test still passes.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9205
To:
dhaumann updated this revision to Diff 23518.
dhaumann added a comment.
Use initializer_lists directly
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9205?vs=23513&id=23518
BRANCH
QStringListCleanup (branched from master)
REVISION DETAIL
https://ph
mwolff added a comment.
better than before, but some things could be improved some more
INLINE COMMENTS
> katedocument.cpp:4518
> +// view variable names
> +static const QStringList vvl {
> + QStringLiteral("dynamic-word-wrap")
even better would be to not name this list type
dhaumann created this revision.
dhaumann added a reviewer: mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Simple cleanup of QStringList{...}
TEST PLAN
make test
REPOSITORY
R39 KTextEditor
BRANCH
QS
