This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f9dbd24e80b7: Migrate some QRegExps to QRegularExpression
(authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9168?vs=23491&id=23506#toc
REPOSITORY
R39 KTextEditor
CHANGES
mwolff accepted this revision.
mwolff added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> katedocument.cpp:4475
> // found vars, if any
> QString s;
>
future: this could be a ref, quite probably, and capturedRef could be used below
> katedocumen
dhaumann marked an inline comment as done.
dhaumann added a comment.
Update patch.
INLINE COMMENTS
> mwolff wrote in katecmds.cpp:502
> static?
I do not think static is needed here: When you invoke the command line (F7),
and type 'char 0x123', then creating a QRegularExpression will not be
dhaumann updated this revision to Diff 23491.
dhaumann marked 4 inline comments as done.
dhaumann added a comment.
Remove one usage of QRegularExpression
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9168?vs=23488&id=23491
BRANCH
QRegExpCleanup (bran
dhaumann updated this revision to Diff 23488.
dhaumann added a comment.
Fix remarks by Milian.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9168?vs=23424&id=23488
BRANCH
QRegExpCleanup (branched from master)
REVISION DETAIL
https://phabricator.kd
mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> katewordcompletion.cpp:316
> KTextEditor::Cursor dcCursor; // directional completion search cursor
> -QRegExp re; // hrm
> +QRegular
dhaumann created this revision.
dhaumann added reviewers: cullmann, kfunk, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Please make a careful review. Many of these code
changes are most likely not touch
