apol abandoned this revision.
apol marked an inline comment as done.
apol added a subscriber: mlaurent.
apol added a comment.
:( when I rebased to current master I realized that @mlaurent worked on a
very similar patch without going through review (which btw is policy in KDE
Frameworks).
apol marked 2 inline comments as done.
apol added a comment.
Thanks!
INLINE COMMENTS
> dhaumann wrote in kiconeffect.cpp:165
> Previously, this was not an else if(), but just an if().
>
> Are you sure this works as intended?
Yes, `effectGroupState` is not going to change values out of the b
dhaumann added a comment.
Looks already pretty just. I just stumbled over two issues which maybe should
be clarified - see comments.
INLINE COMMENTS
> kiconeffect.cpp:163
> +
> +if (state == Colorize || effectGroupState == ToMonochrome) {
> +cached += QLatin1Char(':') + d
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Instead of using implicit casts, use the ones we need as suggested for KF5.
TEST PLAN
Builds, tests pass
REPOSITORY
R302 KIconThemes
BRANCH
master
REVISIO
