This revision was automatically updated to reflect the committed changes.
Closed by commit R296:0ecea38b5998: Setup QQmlEngine only once in QmlObject
(authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9141?vs=28691&id=28728#toc
REPOSITORY
R296 KDeclarative
CHANGES S
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
i like it now
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9141
To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, michaelh,
broulik updated this revision to Diff 28691.
broulik edited the test plan for this revision.
broulik added a comment.
- Use protected constructor with pseudo argument instead of flags
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9141?vs=23360&id=2869
broulik added inline comments.
INLINE COMMENTS
> mart wrote in qmlobject.h:72
> what about a different ctor which does that, but without exposing that enum?
What signature should I use for the constructor?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9141
To:
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in qmlobject.h:72
> The problem being solved is that QQmlObjectSharedEngine inherits QQmlObject
> that needs a constructor that doesn't do engine things
>
> It could be protected though.
what about a different ctor which does th
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in qmlobject.h:72
> this shouldn't be necessary?
>
> qmoobject will do things engine-wise, the qmlsharedengine subclass will
> always do things context-wise without new public constructors?
The problem being solved is that QQml
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> qmlobject.h:72
> + */
> +enum class SetupFlag {
> +Engine = 1<<0, ///< call setupEngine() on it
this shouldn't be necessary?
qmoobject will do th
hein added subscribers: mart, hein.
hein added a comment.
Looks good to me, but @mart needs to have a look too.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9141
To: broulik, #plasma
Cc: hein, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
`setupBindings` is called for every `QmlObject` created and installs various
bits on t
