D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#198423, @asturmlechner wrote: > Want me to fix FindQtWaylandScanner.cmake in the same way? Sure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, c

D9116: Make sure to search for Qt5-based qmlplugindump

This revision was automatically updated to reflect the committed changes. Closed by commit R240:92eb3e9767cb: Make sure to search for Qt5-based qmlplugindump (authored by asturmlechner). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9116?vs=26253&

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. Want me to fix FindQtWaylandScanner.cmake in the same way? REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks, #buil

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system,

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner edited the summary of this revision. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system, michaelh, ngraham

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner updated this revision to Diff 26253. asturmlechner added a comment. Use ECMQueryQmake.cmake as suggested. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9116?vs=23304&id=26253 BRANCH arcpatch-D9116 REVISION DETAIL https://pha

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#186638, @asturmlechner wrote: > Can we move forward with this? ECM provides ECMQueryQmake.cmake. you can try eg: include("${ECM_MODULE_DIR}/ECMQueryQmake.cmake") then calling query_qmake(qt_binaries_dir QT_INS

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. Can we move forward with this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. In https://phabricator.kde.org/D9116#174894, @aacid wrote: > is this a problem caused by qmlplugindump being one of those magic things that are "symlinks" to the qt4 or qt5 depending on the QT_SELECT env var? exactly REPOSITORY R240 Extra CMake Mo

D9116: Make sure to search for Qt5-based qmlplugindump

aacid added a comment. is this a problem caused by qmlplugindump being one of those magic things that are "symlinks" to the qt4 or qt5 depending on the QT_SELECT env var? maybe makes more sense to fix the execute_process so that it sets QT_SELECT to 5? REPOSITORY R240 Extra CMake Modu

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner added a comment. In https://phabricator.kde.org/D9116#174856, @dfaure wrote: > Which distro was this commit for? Looks like a debian/ubuntu path? If so, how did this go unnoticed until now? This is for Gentoo - now I don't do Qt packaging, but as far as I'm aware th

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#174856, @dfaure wrote: > Well, it's just a hint. If it's not found there, no harm done. But yeah, at least the paths for most distros could be there, to be fair ;) > > For OpenSuSE no change needed, it's in /usr/bin.

D9116: Make sure to search for Qt5-based qmlplugindump

dfaure added a comment. Well, it's just a hint. If it's not found there, no harm done. But yeah, at least the paths for most distros could be there, to be fair ;) For OpenSuSE no change needed, it's in /usr/bin. Which distro was this commit for? Looks like a debian/ubuntu path? If so

D9116: Make sure to search for Qt5-based qmlplugindump

cgiboudeaux added a comment. -1 this will not work for anyone. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol Cc: cgiboudeaux, #frameworks, #build_system

D9116: Make sure to search for Qt5-based qmlplugindump

asturmlechner created this revision. asturmlechner added a reviewer: apol. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Without any hint, qmlplugindump version is whatever default is set by