D9110: Cache value before loop

2017-12-02 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R246:8de9d6953c0f: Cache value before loop (authored by mlaurent). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9110?vs=23305&id=23307 REVISION DETAIL https://phabri

D9110: Cache value before loop

2017-12-02 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH avoid_check_all_the_time REVISION DETAIL https://phabricator.kde.org/D9110 To: mlaurent, dfaure, sandsmark Cc: #frameworks

D9110: Cache value before loop

2017-12-02 Thread Laurent Montel
mlaurent updated this revision to Diff 23305. mlaurent added a comment. - Make boolean as const for readibility REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9110?vs=23291&id=23305 BRANCH avoid_check_all_the_time REVISION DETAIL https://phabricator.kd

D9110: Cache value before loop

2017-12-02 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Good idea. INLINE COMMENTS > backgroundchecker.cpp:59 > sentenceOffset=-1; > +bool autodetectLanguage = > currentDict.testAttribute(Speller::AutoDetectLanguage);

D9110: Cache value before loop

2017-12-02 Thread Laurent Montel
mlaurent added reviewers: dfaure, sandsmark. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9110 To: mlaurent, dfaure, sandsmark Cc: #frameworks

D9110: Cache value before loop

2017-12-02 Thread Laurent Montel
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R246 Sonnet BRANCH avoid_check_all_the_time REVISION DETAIL https://phabricator.kde.org/D9110 AFFECTED FILES src/core/backgroundchecker.c