This revision was automatically updated to reflect the committed changes.
Closed by commit R241:befcbbd4e36b: Add undo support to BatchRenameJob
(authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9107?vs=23290&id=23340
REVISION DETAIL
https:
dfaure added a comment.
The RC is tagged, you can push.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9107
To: chinmoyr, #frameworks, dfaure
Cc: aspotashev
aspotashev added a comment.
Please don't push this while in string freeze because you added a new
translatable ('i18n()') message.
https://community.kde.org/Schedules/Frameworks
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9107
To: chinmoyr, #fr
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9107
To: chinmoyr, #frameworks, dfaure
chinmoyr updated this revision to Diff 23290.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.
minor changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9107?vs=23275&id=23290
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Good stuff.
INLINE COMMENTS
> fileundomanagertest.cpp:697
> +
> +createTestFile(srcList[0].path(), "foo");
> +createTestFile(srcList[1].path(), "foo");
use .at(0) to avoi
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch makes undoing a batch rename possible.
Depends on https://phabricator.kde.org/D9103
REPOSITORY
R241 KIO
BRANCH
master
REVISION
