This revision was automatically updated to reflect the committed changes.
Closed by commit R241:12bf704476c6: Add BatchRenameJob to KIO (authored by
chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23306&id=23337
REVISION DETAIL
https://phabric
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks!
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9103
To: chinmoyr, #frameworks, dfaure
Cc: apol
chinmoyr updated this revision to Diff 23306.
chinmoyr added a comment.
removed exception for ERR_FILE_ALREADY_EXISTS.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23299&id=23306
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9103
A
dfaure added inline comments.
INLINE COMMENTS
> chinmoyr wrote in batchrenamejob.cpp:196
> If the job isn't interactive (like in unit test) then it ends with
> ERR_FILE_ALREADY_EXIST error. In case of unit test ignoring the error seems
> quite harmless.
Ah, yes, makes sense when non-interactiv
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in batchrenamejob.cpp:196
> Ah right KIO::moveAs itself pops up the overwrite dialog, but then can it end
> with KIO::ERR_FILE_ALREADY_EXIST ? At that point the user should overwrite or
> skip or cancel. Are you really sure this err
chinmoyr updated this revision to Diff 23299.
chinmoyr added a comment.
changed 'first' to 'pos'.
added one more example to the doc.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23286&id=23299
BRANCH
master
REVISION DETAIL
https://phabricator.
dfaure added inline comments.
INLINE COMMENTS
> chinmoyr wrote in batchrenamejob.cpp:75
> Here it is searching for exactly one sequence. If more than one sequence are
> present like $$file$$name$$ then it is considered invalid.
But why? Why doesn't this lead to 12file$$name$$?
It's a weird inp
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in batchrenamejob.cpp:55
> Why special case "not a sequence", rather than just replacing the first
> (last?) sequence?
Because there might not be a first or last sequence present. In case 3 we don't
need a replacement and in case 4
chinmoyr updated this revision to Diff 23286.
chinmoyr marked 13 inline comments as done.
chinmoyr added a comment.
Hopefully I haven't missed any more of your comments.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23281&id=23286
BRANCH
master
REV
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> batchrenamejob.cpp:56
> +// In this case nothing is substituted and all files have the same
> $newName.
> +// 4. Atleast two files have same e
chinmoyr updated this revision to Diff 23281.
chinmoyr marked 10 inline comments as done.
chinmoyr added a comment.
Made the required changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23272&id=23281
BRANCH
master
REVISION DETAIL
https://phabr
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I'm OK with this being in KIO. One day we might want the same from the file
dialog, or krusader, etc.
INLINE COMMENTS
> batchrenamejobtest.cpp:20
> +
> +#include
> +
this is al
chinmoyr added a dependent revision: D9107: Add undo support to BatchRenameJob.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9103
To: chinmoyr, #frameworks, dfaure
Cc: apol
chinmoyr updated this revision to Diff 23272.
chinmoyr added a comment.
Emit both old and new url in fileRenamed. It will be useful when undoing.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23260&id=23272
BRANCH
master
REVISION DETAIL
https://p
chinmoyr added a comment.
In https://phabricator.kde.org/D9103#174381, @apol wrote:
> Wouldn't it be easier to have this job in Dolphin? Or it needs to be in kio
to access private API?
Adding undo support is easier if it's in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://
apol added a comment.
Wouldn't it be easier to have this job in Dolphin? Or it needs to be in kio
to access private API?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9103
To: chinmoyr, #frameworks, dfaure
Cc: apol
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This job will be used to rename multiple files. It basically reuses the code
from `Dolphin::RenameDialog`.
REPOSITORY
R241 KIO
BRANCH
master
17 matches
Mail list logo
