D9049: Compile with stricter compilation flags

2017-12-02 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R263:7005889ba644: Compile with stricter compilation flags (authored by mlaurent). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9049?vs=23199&id=23270 REVISION DETAIL

D9049: Compile with stricter compilation flags

2017-12-01 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH fix_strict_compile REVISION DETAIL https://phabricator.kde.org/D9049 To: mlaurent, dfaure Cc: apol, #frameworks

D9049: Compile with:

2017-11-30 Thread Laurent Montel
mlaurent updated this revision to Diff 23199. mlaurent marked 3 inline comments as done. mlaurent added a comment. - Port to QByteArray. Add missing const. Fix error found by David REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9049?vs=23133&id=23199 BRANC

D9049: Compile with stricter compilation flags

2017-11-30 Thread Laurent Montel
mlaurent retitled this revision from "Compile with:" to "Compile with stricter compilation flags". mlaurent edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9049 To: mlaurent, dfaure Cc: apol, #frameworks

D9049: Compile with:

2017-11-29 Thread David Faure
dfaure added a comment. The commit log needs to have a one-line summary, like "Compile with stricter compilation flags". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9049 To: mlaurent, dfaure Cc: apol, #frameworks

D9049: Compile with:

2017-11-29 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > mlaurent wrote in kactioncollectiontest.cpp:235 > we use latin1 for kstandardaction::name no ? For me it seems that we didn"t > add a no latin1 name for it. Yeah, standard action names are definitely latin1. Actions defined by applications, howev

D9049: Compile with:

2017-11-29 Thread Laurent Montel
mlaurent added inline comments. INLINE COMMENTS > apol wrote in kactioncollectiontest.cpp:235 > I'd expect these to be Utf8. we use latin1 for kstandardaction::name no ? For me it seems that we didn"t add a no latin1 name for it. > apol wrote in smtp.cpp:226 > Are you sure it shouldn't be `fro

D9049: Compile with:

2017-11-29 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kactioncollectiontest.cpp:235 > QVERIFY(a->parent() == &collection); > -QVERIFY(collection.action(KStandardAction::name(KStandardAction::Undo)) > == a); > + > QVERIFY(collection.action(QString::fromLatin1(KStandardAction::name(KStandardA

D9049: Compile with:

2017-11-29 Thread Laurent Montel
mlaurent added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9049 To: mlaurent, dfaure Cc: #frameworks

D9049: Compile with:

2017-11-29 Thread Laurent Montel
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - DQT_NO_CAST_FROM_BYTEARRAY - QT_NO_CAST_FROM_ASCII - QT_NO_CAST_TO_ASCII REPOSITORY R263 KXmlGui BRANCH fix_strict_compile REVI