This revision was automatically updated to reflect the committed changes.
Closed by commit R289:4b4062497afc: Make it compile with QT_NO_CAST_FROM_ASCII
(authored by mlaurent).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9027?vs=23069&id=23070
REVIS
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
make_it_compile_with_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabricator.kde.org/D9027
To: mlaurent, dfaure
Cc: #frameworks
mlaurent updated this revision to Diff 23069.
mlaurent marked 5 inline comments as done.
mlaurent added a comment.
- Fix comment found by david
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9027?vs=23062&id=23069
BRANCH
make_it_compile_with_QT_NO
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> knotificationmanager.cpp:87
> if (!runtimeDir.isEmpty()) {
> -inSandbox = QFileInfo::exists(QFile::encodeName(runtimeDir) +
> QLatin1Stri
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
compile execute autotest
REPOSITORY
R289 KNotifications
BRANCH
make_it_compile_with_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabrica
mlaurent added a reviewer: dfaure.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D9027
To: mlaurent, dfaure
Cc: #frameworks
