This revision was automatically updated to reflect the committed changes.
Closed by commit R292:f3342f4ccaba: Port from QDom to QXmlStreamReader
(authored by broulik).
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8971?vs=22874&id=23289
REVISION DETA
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8971
To: broulik, #frameworks, dfaure
Cc: apol, anthonyfieroni
broulik updated this revision to Diff 22874.
broulik added a comment.
- Use `qFuzzyIsNull`
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8971?vs=22838&id=22874
REVISION DETAIL
https://phabricator.kde.org/D8971
AFFECTED FILES
CMakeLists.txt
apol added a comment.
+1
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8971
To: broulik, #frameworks
Cc: apol, anthonyfieroni
broulik added a comment.
`qFuzzyIsNull` rather. The original code didn't even check ..
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8971
To: broulik, #frameworks
Cc: anthonyfieroni
anthonyfieroni added inline comments.
INLINE COMMENTS
> currency.cpp:713
> +const auto multiplier =
> attributes.value(QLatin1String("rate")).toDouble();
> +if (multiplier != 0) {
> +unit.setUnitMultiplier(1.
broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The Qt Xml module is not actively maintained anymore and docs suggest to use
QXmlStreamReader. Also removes the dependency on Qt Xml
TEST PLAN
I can still
