asturmlechner added a comment.
Herald added a subscriber: kde-frameworks-devel.
FYI, after
https://invent.kde.org/frameworks/kwindowsystem/-/commit/5cc5734b46cd3bcc2a35402718731cdae5000803
and
https://invent.kde.org/frameworks/kwindowsystem/-/commit/374a29075694f530d2d0673e33a166c83
graesslin added a comment.
In https://phabricator.kde.org/D8705#166045, @dfaure wrote:
> I guess that the same argument could be made about Qt5::Widgets... if
you're using a widget you're supposed to link to that, rather than indirectly
via KWindowSystem...
>
> This is making me chan
dfaure added a comment.
Qt doesn't have files like KF5WindowSystemConfig.cmake.in :)
I guess you mean changing #includes in public headers, but this is also about
changing the library dependencies, which I have never seen change in Qt.
Now that you remind me that Qt sometimes change
apol added a comment.
Qt has this kind of changes all the time and I've never seen a complaint.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D8705
To: apol, #frameworks, dfaure
Cc: graesslin, dfaure, anthonyfieroni
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
That is indeed source incompatible (apart from the change to the _p.h
headers). You can either just add a "TODO KF6" comment, or provide a cmake
option for linking to QtWidgets, b
graesslin added subscribers: dfaure, graesslin.
graesslin added a comment.
From my side a -1. This is not source compatible. Thus I think we need to
wait for Frameworks 6 for it.
I want @dfaure to ack/nack this change.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricato
anthonyfieroni added a comment.
One more place -> kselectionowner.cpp:37
Dropping can't be done before KF6 :)
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D8705
To: apol, #frameworks
Cc: anthonyfieroni
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Make it a private dependency for now, until we can possibly drop it from the
library
TEST PLAN
Built the rest of projects, including plasma, will send few patc
