This revision was automatically updated to reflect the committed changes.
Closed by commit R241:549fc81e8e8a: Don't check whether an empty filename
exists (authored by elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8697?vs=22035&id=23106
REVISIO
dfaure added a comment.
Personally, I don't find a check in QFile/QFileInfo "much cleaner". It's an
invalid call, arguably. So checking here makes sense.
REPOSITORY
R241 KIO
BRANCH
fix-empty-exists
REVISION DETAIL
https://phabricator.kde.org/D8697
To: elvisangelaccio, dfaure
Cc: apol
elvisangelaccio added a comment.
In https://phabricator.kde.org/D8697#165670, @apol wrote:
> Here's an alternative: https://codereview.qt-project.org/210716
That would be much cleaner indeed, I'll hold this patch for now.
REPOSITORY
R241 KIO
BRANCH
fix-empty-exists
REVISION
apol added a comment.
Here's an alternative: https://codereview.qt-project.org/210716
REPOSITORY
R241 KIO
BRANCH
fix-empty-exists
REVISION DETAIL
https://phabricator.kde.org/D8697
To: elvisangelaccio, dfaure
Cc: apol, #frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
fix-empty-exists
REVISION DETAIL
https://phabricator.kde.org/D8697
To: elvisangelaccio, dfaure
Cc: #frameworks
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Since 5.10 (commit 0dee566e98 in qtbase) Qt complains if we make a
system call with an em
