This revision was automatically updated to reflect the committed changes.
Closed by commit R245:a3c7bf02205f: Faster UDevManager::devicesFromQuery
(authored by davidedmundson).
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8495?vs=23086&id=23264
REVISION DETAI
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> udevmanager.cpp:182
> +const UdevQt::DeviceList deviceList = d->m_client->allDevices();
> +Q_FOREACH (const UdevQt::Device &dev, deviceList) {
> +
davidedmundson edited the summary of this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D8495
To: davidedmundson
Cc: #frameworks
davidedmundson updated this revision to Diff 23086.
davidedmundson added a comment.
Rewrite, changes less stuff.
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8495?vs=21368&id=23086
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8495
AFFEC
davidedmundson planned changes to this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D8495
To: davidedmundson
Cc: #frameworks
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The current code fetches all devices, filters isOfInterest (which is at
least one device property lookup) then filters by type.
