D8371: Support for underscores in numeric literals (Python 3.6)

2018-02-01 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0abe7dab204f: Support for underscores in numeric literals (Python 3.6) (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8371?vs=24

D8371: Support for underscores in numeric literals (Python 3.6)

2018-02-01 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good. If you have more updates, please let us know by sending more patches :-) REPOSITORY R216 Syntax Highlighting BRANCH python_separators REVISION DETAIL https://phabric

D8371: Support for underscores in numeric literals (Python 3.6)

2017-12-22 Thread Diego Gangl
januz added a comment. Thanks for the tips guys! This patch still has two problems (that I'm aware :) ): - I can't get it to match the dot in the float regex. The regex itself is ok (https://regexr.com/3idtj), but it just doesn't work. - The regexes don't work inside lists or dicti

D8371: Support for underscores in numeric literals (Python 3.6)

2017-12-22 Thread Diego Gangl
januz updated this revision to Diff 24317. januz added a comment. - Tweaked regexes to fit better with the other regex in the file - Version bump - Added autotests and updated references REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8371?vs

D8371: Support for underscores in numeric literals (Python 3.6)

2017-12-10 Thread Dominik Haumann
dhaumann added a comment. Btw: To update the reference, you can simply execute build/frameworks/syntax-highlighting/autotests/update-reference-data.sh Note, this script is in your *build* folder (not the git checkout folder). REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D8371: Support for underscores in numeric literals (Python 3.6)

2017-12-10 Thread Christoph Cullmann
cullmann added a comment. In https://phabricator.kde.org/D8371#178009, @januz wrote: > In https://phabricator.kde.org/D8371#177673, @cullmann wrote: > > > b) an extended unit test would be nice, to really show that the regex are right. > > > Hi, sure. Is there any documentation

D8371: Support for underscores in numeric literals (Python 3.6)

2017-12-09 Thread Diego Gangl
januz added a comment. In https://phabricator.kde.org/D8371#177673, @cullmann wrote: > b) an extended unit test would be nice, to really show that the regex are right. Hi, sure. Is there any documentation on how to make those tests? I noticed there are some ref and input files, d

D8371: Support for underscores in numeric literals (Python 3.6)

2017-12-08 Thread Christoph Cullmann
cullmann added a comment. Hi, I assume the regex are right ;=) For the patch: a) I think the version number must be increased b) an extended unit test would be nice, to really show that the regex are right. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricato

D8371: Support for underscores in numeric literals (Python 3.6)

2017-10-19 Thread Christoph Feck
cfeck added a reviewer: Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8371 To: januz, #kate Cc: #frameworks, cullmann, vkrause, dhaumann

D8371: Support for underscores in numeric literals (Python 3.6)

2017-10-19 Thread Christoph Feck
cfeck edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8371 To: januz Cc: #frameworks, cullmann, vkrause, dhaumann

D8371: Support for underscores in numeric literals (Python 3.6)

2017-10-19 Thread Diego Gangl
januz created this revision. januz added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds support for underscores in numeric literals for Python 3.6 (from PEP 51