This revision was automatically updated to reflect the committed changes.
Closed by commit R127:f48b796c74d5: Don't duplicate connect to
wl_display_flush (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8284?vs=20708&id=20744
REVI
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Ahhh. That's of course tricky to spot in this change ;-)
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson, graesslin
davidedmundson added a comment.
The other ctor has a connect in the body.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai, ali-mohamed, jensreuterberg
graesslin added a comment.
I don't see in the change what you describe. This seems to be just a
refactoring.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
les
davidedmundson created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
When using the QPA's wl_display, we don't need to also flush when the
event dispatcher blocks, as Qt'