davidedmundson abandoned this revision.
davidedmundson added a comment.
Edit. Didn't see that Ngraham had changed this also.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8024
To: davidedmundson, cfeck
Cc: ngraham, #frameworks
ngraham added a comment.
Hmm, I think edit-delete is the correct icon here, for two reasons:
1. That's what upstream Qt defaults to
2. dialog-cancel is more appropriate for a Cancel button (in fact that's what
cancel is already using). But Discard is a more destructive action than Cance
cfeck added a comment.
Hm, bug 385158 says we should use "edit-delete". Not sure who is right.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8024
To: davidedmundson, cfeck
Cc: #frameworks
cfeck accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8024
To: davidedmundson, cfeck
Cc: #frameworks
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
In frameworkintegration/src/kstyle/kstyle.cpp it is set to dialog-cancel
But here the standard item defaults to something else
