mardelle abandoned this revision.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7954
To: mardelle, #frameworks, ilic, dfaure
Cc: michaelh
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
You can discard this, I killed the code completely, with my change to
kwidgetaddons.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7954
To: mardelle,
dfaure added a comment.
Ah right, my comment was wrong, it assumed that `text` was the current text
of `tb`, but it's not (necessarily).
So your patch is ok, it's just that I'd rather remove all this code with my
other patch instead ;)
But until it's approved, let's have yours in...
R
mardelle added a comment.
So did some more tests, and the loop is caused by the tb->settext() call. The
QAbstractButton setText method checks if :
d->text == text
But d->text contains the & accel marker and not text, so we end up comparing
'ren&der' with 'render' on paint, thus the loo
dfaure added a comment.
Uploaded my patch, now with unittest: https://phabricator.kde.org/D7964
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7954
To: mardelle, #frameworks, ilic, dfaure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
OK, let's get the quick fix in, but I still think my alternative patch
(removing all this code and applying
http://www.davidfaure.fr/2017/0001-KAcceleratorManager-set-icon-text-on-actions-t
mardelle created this revision.
mardelle added reviewers: Frameworks, ilic, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Patch is based on https://git.reviewboard.kde.org/r/128421/
This issue - endless repaint loop when a QToolButton is embedded in a
KToolBar -
