cgiboudeaux added a comment.
In https://phabricator.kde.org/D7823#164880, @marten wrote:
> In https://phabricator.kde.org/D7823#164879, @cfeck wrote:
>
> > Are the copies in the attic directory still needed for compatibility
reasons, or can they get removed?
>
>
> No needed by a
marten added a comment.
In https://phabricator.kde.org/D7823#164879, @cfeck wrote:
> Are the copies in the attic directory still needed for compatibility
reasons, or can they get removed?
No needed by anything within Frameworks, Plasma or Applications as far as I'm
aware. Shall
cfeck added a comment.
Are the copies in the attic directory still needed for compatibility reasons,
or can they get removed?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux, cfeck,
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ee5b036c1df4: Add FindGLIB2.cmake and
FindPulseAudio.cmake (authored by marten).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7823?vs=19611&id=21961#toc
REPOSITORY
R240 Extra CMake Modules
cgiboudeaux added a comment.
In https://phabricator.kde.org/D7823#164474, @cgiboudeaux wrote:
> Don't forget to create .rst files in doc/find-module and change 'Since
5.39.0' to 'Since 5.40.0'
'5.41.0', sorry
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabri
cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.
No news from the ECM maintainer, please push.
Don't forget to create .rst files in doc/find-module and change 'Since
5.39.0' to 'Since 5.40.0'
REPOSITORY
R240 Extra CMake Mod
marten added a comment.
Ping anyone?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
marten marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
marten updated this revision to Diff 19611.
marten added a comment.
Diff updated to move library target definition after
find_package_handle_standard_args.
If these modules are accepted into ECM then KMix needs a further commit
anyway, in order to remove the final requirement for KDELibs
cgiboudeaux added a comment.
Looks good. What's your migration plan ?
if you don't want to bump the ECM requirements for applications looking for
pulseaudio, you have to set some compatibility/deprecated vars (eg: kmix uses
uppercase variables)
INLINE COMMENTS
> FindPulseAudio.cmake:109
>
marten marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
marten updated this revision to Diff 19576.
marten marked an inline comment as done.
marten added a comment.
Updated as per review comments.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7823?vs=19570&id=19576
REVISION DETAIL
https://phabric
marten marked 17 inline comments as done.
marten added a comment.
Diff updated.
INLINE COMMENTS
> cgiboudeaux wrote in FindPulseAudio.cmake:8-19
> It's a new module, change PULSEAUDIO to PulseAudio to match the module name.
PULSEAUDIO -> PulseAudio changed throughout
REPOSITORY
R240 Extra
cgiboudeaux added inline comments.
INLINE COMMENTS
> FindGLIB2.cmake:10
> +# True if the GLib2 library is available
> +# ``GLIB2_INCLUDE_DIR``
> +# The GLib2 include directory
Call it GLIB2_INCLUDE_DIRS.
> FindGLIB2.cmake:43
> +#
> +# For details see the accompanying COPYING-CMAKE-SCRIP
marten updated this revision to Diff 19570.
marten added a comment.
Modules updated with standard header, documentation and copyright; endif()
used throughout.
Yes, Phonon does not use ECM but the modules there are very different to
those in ECM anyway.
Within Plasma+applications thes
cgiboudeaux added a comment.
-1. They don't match the ECM coding style and code quality (doc, license,
endif(), pkgconfig...)
And :
> kdelibs4support/cmake/modules/FindGLIB2.cmake
> ecm/attic/modules/FindGLIB2.cmake
These two are there for legacy purpose.
> phonon/cmake/
marten added a comment.
It's the same source really - the only differences between those in
kdelibs4support and ecm/attic are that the former uses endif(same_as_if) and
the latter uses endif().
Nothing else within Frameworks, Plasma or applications uses anything from
ecm/attic directly.
R
cfeck added a comment.
In other words, your suggestion is not to add it to ecm, but to move it from
attic/modules to find-modules.
That raises the question, how one is supposed to use the attic modules,
without copying them manually.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAI
marten added a subscriber: heikobecker.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: heikobecker
marten created this revision.
Restricted Application added projects: Frameworks, Build System.
REVISION SUMMARY
These modules are used in a number of places within Frameworks, Plasma and
dependencies:
FindGLIB2:
plasma-desktop/applets/kimpanel/cmake/FindGLIB2.cmake
kdelibs4suppo
20 matches
Mail list logo
