D7645: Add highlighting for QDoc configuration files

2017-09-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:251e5e1a9392: Add highlighting for QDoc configuration files (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7645?vs=19070&id=19084

D7645: Add highlighting for QDoc configuration files

2017-09-01 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > vkrause wrote in qdocconf.xml:94 > Yes, due to the LineContinue rule. The test case fails in two places without > that, line 47 and 57, the empty line preceding those doesn't pop due to the > line continuation the line before. Ah. Nice. So this

D7645: Add highlighting for QDoc configuration files

2017-09-01 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > dhaumann wrote in qdocconf.xml:14 > Is the capital c intentional? yep, both according to the qdoc docs and real files > dhaumann wrote in qdocconf.xml:94 > Given lineEndContext is pop, do we need the lineEmptyContext? Yes, due to the LineContinu

D7645: Add highlighting for QDoc configuration files

2017-09-01 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. INLINE COMMENTS > qdocconf.xml:14 > +buildversion > +Cpp > +customFilters Is the capital c intentional? > qdocconf.xml:94 > + > +

D7645: Add highlighting for QDoc configuration files

2017-09-01 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7645 AFFECTED FILES autotests/folding/test.qdocconf.fo