D7563: Add privilegeExecution field to file protocol description

cblack abandoned this revision. cblack added a comment. Moving this to GitLab: https://invent.kde.org/frameworks/kio/-/merge_requests/143 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter,

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83347. cblack marked an inline comment as done. cblack added a comment. i18n the strings REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=83344&id=83347 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.k

D7563: Add privilegeExecution field to file protocol description

sitter added a comment. In D7563#676151 , @cblack wrote: > In D7563#674682 , @sitter wrote: > > > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too mu

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. Oh and thanks for taking this over, @cblack. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham,

D7563: Add privilegeExecution field to file protocol description

ngraham added inline comments. INLINE COMMENTS > file_unix.cpp:1349 > +case ActionType::UTIME: return QStringLiteral("Authentication is > required to modify this file's last updated time."); > +case ActionType::UNKNOWN: return QStringLiteral("Authentication is > required to pe

D7563: Add privilegeExecution field to file protocol description

cblack marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, michael

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83344. cblack added a comment. Redo that switchcase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=83343&id=83344 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES src/co

D7563: Add privilegeExecution field to file protocol description

sitter added inline comments. INLINE COMMENTS > file_unix.cpp:1372 > +break; > +default: > +Q_UNREACHABLE(); I'd advise handling default cases. The compiler can no longer warn of unhandled enum values when default is used. Instead I'd convert the entire switch into a helper

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83343. cblack added a comment. Break those cases; this lang ain't got sane case behaviour REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=83342&id=83343 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83342. cblack marked an inline comment as done. cblack added a comment. Add more descriptive authentication details REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80668&id=83342 BRANCH arcpatch-D7563 REVISION DET

D7563: Add privilegeExecution field to file protocol description

cblack commandeered this revision. cblack added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisan

D7563: Add privilegeExecution field to file protocol description

cblack added a comment. In D7563#674682 , @sitter wrote: > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs when certa

D7563: Add privilegeExecution field to file protocol description

feverfew added a comment. In D7563#674682 , @sitter wrote: > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs when cer

D7563: Add privilegeExecution field to file protocol description

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs wh

D7563: Add privilegeExecution field to file protocol description

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

feverfew added a comment. In D7563#653171 , @elvisangelaccio wrote: > In D7563#650117 , @ngraham wrote: > > > [insert I-have-no-idea-what-I'm-doing dog meme here] > > > > When trying to create item

D7563: Add privilegeExecution field to file protocol description

elvisangelaccio added a comment. In D7563#650117 , @ngraham wrote: > [insert I-have-no-idea-what-I'm-doing dog meme here] > > When trying to create items in root-owned locations, I'm getting an errors saying "The process for the file protocol

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80668. ngraham added a comment. Maybe fix a thing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80645&id=80668 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES src/cor

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80645. ngraham added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80644&id=80645 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES src/core/kfileitem

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80644. ngraham added a comment. Install auth helper too REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80343&id=80644 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES s

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. [insert I-have-no-idea-what-I'm-doing dog meme here] When trying to create items in root-owned locations, I'm getting an errors saying "The process for the file protocol died unexpectedly." or else Dolphin simply crashes with a totally unhelpful backtrace. REPOS

D7563: Add privilegeExecution field to file protocol description

chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file_unix.cpp:1331 > +KAuth::Action::DetailsMap details; > +details.insert(KAuth::Action::AuthDetail::DetailMessage, > QStringLiteral("Authenticat

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80343. ngraham added a comment. Set the patch base REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80342&id=80343 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES src/co

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80342. ngraham added a comment. - Fix build failure - Add more stuff (thanks @chinmoyr) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80341&id=80342 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator

D7563: Add privilegeExecution field to file protocol description

ngraham commandeered this revision. ngraham added a reviewer: chinmoyr. ngraham added a comment. Yoink! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865,

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. Thanks @chinmoyr! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

chinmoyr updated this revision to Diff 80341. chinmoyr marked an inline comment as done. chinmoyr added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Rebased on master. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. @chinmoyr phab reports that this has a missing dependency/patch base. Is there some unmerged patch that's left to do, or does it just need a rebase on master? BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc:

D7563: Add privilegeExecution field to file protocol description

elvisangelaccio added a comment. In D7563#645172 , @ngraham wrote: > The outstanding security issues have been resolved (see T8075 ). We have requested a re-review from the SUSE security team, but have not recei

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. The outstanding security issues have been resolved (see T8075 ). We have requested a re-review from the SUSE security team, but have not received it yet. Given that the original schedule for this feature has already slipped by almos

D7563: Add privilegeExecution field to file protocol description

chinmoyr added a comment. In D7563#23 , @ngraham wrote: > What's the status of this patch? I will push this patch after fixing all security issues with kauth support in KIO. (T8075 ) BRANCH master

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. What's the status of this patch? BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc: ngraham, elvisangelaccio

D7563: Add privilegeExecution field to file protocol description

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kprotocolmanager.h:479 > + */ > +static bool supportsPrivilegeExecution(const QUrl &url); > + Missing @since 5.39 BRANCH master REVISION DETAIL https://ph

D7563: Add privilegeExecution field to file protocol description

chinmoyr added a dependent revision: D7571: Enable modifying root-owned files in Dolphin. REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc: elvisangelaccio

D7563: Add privilegeExecution field to file protocol description

chinmoyr added a task: T6561: Polkit support in KIO. REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc: elvisangelaccio

D7563: Add privilegeExecution field to file protocol description

chinmoyr created this revision. REVISION SUMMARY "privilegeExecution" field will specify if protocol can perform file operation with elevated privileges. Dolphin relies on `KFileItemListProperties` for enabling some of its context menu actions. Internally `KFileItemListProperties` uses `