D7430: Add unit test

2017-11-07 Thread Nathaniel Graham
ngraham added a comment. How are we doing here? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7430 To: chinmoyr, dfaure Cc: ngraham, #frameworks

D7430: Add unit test

2017-09-03 Thread David Faure
dfaure added a comment. Also please improve the commit log to be more self contained (unit tests for what? And "https://phabricator.kde.org/T6561"; will mean nothing to someone doing `git log`). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7430 To: chinmoyr, dfaure

D7430: Add unit test

2017-09-03 Thread David Faure
dfaure added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7430 To: chinmoyr, dfaure Cc: #frameworks

D7430: Add unit test

2017-09-03 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good, just some minor things. INLINE COMMENTS > privilegejobtest.cpp:37 > +#define KIO_JOB_FLAGS KIO::HideProgressInfo | KIO::PrivilegeExecution > +#define LOCALFILE(x) QUrl

D7430: Add unit test

2017-09-01 Thread Harald Sitter
sitter added a reviewer: dfaure. sitter added a subscriber: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7430 To: chinmoyr, dfaure Cc: #frameworks