martonmiklos added a comment.
In https://phabricator.kde.org/D7367#143391, @cullmann wrote:
> Should be fixed now:
>
> commit
https://phabricator.kde.org/R216:fd79b6842c6f33a1aca4f500354ca2a69c52689e
> Author: Christoph Cullmann
> Date: Wed Sep 6 08:08:49 2017 +0200
>
>
cullmann added a comment.
Should be fixed now:
commit
https://phabricator.kde.org/R216:fd79b6842c6f33a1aca4f500354ca2a69c52689e
Author: Christoph Cullmann
Date: Wed Sep 6 08:08:49 2017 +0200
add missing reference files for tests, looks ok, I think
Differential Revis
cullmann added a comment.
I see, the ref file is missing in autotests/reference
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid
Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
aacid added a comment.
Damnit, i commited it and now the tests are not passing :(
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/89/console
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #frame
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3f9f38a18b60: Added Intel HEX file support for the Syntax
highlighting database (authored by martonmiklos, committed by aacid).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https:
martonmiklos added a comment.
In https://phabricator.kde.org/D7367#143314, @cullmann wrote:
> syntax-highlighting.git, on first glance not landed atm.
>
> Can you commit on your own or should I push it for you Miklos?
Hi guys,
I am on holiday ATM so if you could push it that
aacid set the repository for this revision to R216 Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid
Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
cullmann added a comment.
syntax-highlighting.git, on first glance not landed atm.
Can you commit on your own or should I push it for you Miklos?
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid
Cc: aacid, dhaumann, cu
aacid added a comment.
Which repo is this for?
Has this landed?
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann
Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
aacid requested changes to this revision.
This revision now requires changes to proceed.
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid
Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Ok, I am happy with that ;=)
Now I can look at colorful numbers at work, hehe ;=)
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlight
martonmiklos added a comment.
In https://phabricator.kde.org/D7367#138232, @cullmann wrote:
> Hmm, the diff still looks like it has the old names, perhaps the update
went wrong somehow?
Yepp, I have missed the second page after the diff upload. It should be
correct now.
REVISION
martonmiklos updated this revision to Diff 18514.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7367?vs=18310&id=18514
REVISION DETAIL
https://phabricator.kde.org/D7367
AFFECTED FILES
autotests/html/highlight.hex.html
autotests/input/highlight.hex
data/syntax/intelhex.xml
To:
cullmann added a comment.
Hmm, the diff still looks like it has the old names, perhaps the update went
wrong somehow?
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting, cullmann
Cc: dhaumann, cullmann, #frameworks, vkrause
martonmiklos marked an inline comment as done.
martonmiklos added a comment.
In https://phabricator.kde.org/D7367#138030, @cullmann wrote:
> I am happy beside one thing I missed: I think the file should be called
intelhex.xml, given its for the intel hex format only (the name is already
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I am happy beside one thing I missed: I think the file should be called
intelhex.xml, given its for the intel hex format only (the name is already
fine, did miss that the file
dhaumann added a comment.
@cullmann Since you seem to know this, please take care of this change
request :-)
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting
Cc: dhaumann, cullmann, #frameworks, vkrause
martonmiklos updated this revision to Diff 18310.
martonmiklos added a comment.
Okay so:
- License updated to MIT
- Added detection for invalid RecordType (05<)
- Changed formatting to use builtin formats
- Added autotest case with a sample file with two malformed lines and a HTML
o
martonmiklos added a comment.
In https://phabricator.kde.org/D7367#136687, @cullmann wrote:
> Could you add a minimal example as unit test?
Sure, I have just seen that these xmls could be autotested.
> And could we have as license something like "MIT"?
Sure, I have no obj
dhaumann added a comment.
Please change the kateversion, and as Christoph mentioned please remove
hard-coded colors. You can find a list of all valid default styles here:
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
INLINE COMMENTS
> hex.xml:
cullmann added a comment.
Cool, I use them at work ;=)
Could you add a minimal example as unit test?
And could we have as license something like "MIT"?
For the coloring: it is preferred to use some of our default styles and no
hard coded colors to make color schemes possible.
R
martonmiklos created this revision.
martonmiklos added a project: Framework: Syntax Hightlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I have created an syntax highlight file for the Kate.
The coloring s
22 matches
Mail list logo
