D7280: Add syntax highlighting for Metamath

2017-08-20 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:2baf9eb98c4e: Add syntax highlighting for Metamath (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7280?vs=18373&id=18466 REVISI

D7280: Add syntax highlighting for Metamath

2017-08-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. Will integrate this soon. By the way, you may want to apply for a KDE contributor account to commit your changes yourself, especially since you are providing patch

D7280: Add syntax highlighting for Metamath

2017-08-18 Thread Aaron Puchert
aaronpuchert updated this revision to Diff 18373. aaronpuchert added a comment. Fix commit message and indentation. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7280?vs=18081&id=18373 BRANCH metamath REVISION DETAIL https://phabricator.k

D7280: Add syntax highlighting for Metamath

2017-08-13 Thread Aaron Puchert
aaronpuchert updated this revision to Diff 18081. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Changed license to MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7280?vs=18067&id=18081 BRANCH metamath REVI

D7280: Add syntax highlighting for Metamath

2017-08-13 Thread Aaron Puchert
aaronpuchert marked an inline comment as done. aaronpuchert added a comment. I don't have a commit account, so I'd need you to commit the changes. INLINE COMMENTS > dhaumann wrote in metamath.xml:7 > Can you change the license to MIT? No problem. I was just looking what others were using, an

D7280: Add syntax highlighting for Metamath

2017-08-13 Thread Dominik Haumann
dhaumann added a comment. Looks already pretty good. But please change the license to MIT. We agreed to using MIT license for new syntax-highlighting files. Could you update the review request again? Also can you commit yourself (i.e. Do you have a commit account? ) or shall I commit fo

D7280: Add syntax highlighting for Metamath

2017-08-12 Thread Aaron Puchert
aaronpuchert added a comment. There are screenshots of other (known) syntax highlighters for Metamath on their homepage . REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7280 To: aaronpuchert, #frameworks

D7280: Add syntax highlighting for Metamath

2017-08-12 Thread Aaron Puchert
aaronpuchert created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Metamath is a formal language to express mathematical theorems and proofs developed by Norman Megill. [1, 2] The language is defined in the documentation [3, Chapter 4]. The syntax h