vkrause added inline comments.
INLINE COMMENTS
> kossebau wrote in CMakeLists.txt:91
> This installs KF5AuthTargets.cmake based on the condition, but
> KF5AuthConfig.cmake still includes the target file unconditionally, so cmake
> would fail over missing the file when using find_package(KF5Auth
kossebau added inline comments.
Herald added a subscriber: kde-frameworks-devel.
INLINE COMMENTS
> CMakeLists.txt:91
>
> -install(EXPORT KF5AuthTargets DESTINATION "${CMAKECONFIG_INSTALL_DIR}"
> +if(TARGET KF5Auth)
> +install(EXPORT KF5AuthTargets DESTINATION "${CMAKECONFIG_INSTALL_DIR}"
T
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:af4f0052f1ef: Allow to only build the kauth-policy-gen
code generator (authored by vkrause).
REPOSITORY
R283 KAuth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7274?vs=5&id=22275
RE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R283 KAuth
BRANCH
pending
REVISION DETAIL
https://phabricator.kde.org/D7274
To: vkrause, #frameworks, cordlandwehr, apol
Cc: apol
vkrause updated this revision to Diff 5.
vkrause added a comment.
Integrate review feedback.
REPOSITORY
R283 KAuth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7274?vs=18053&id=5
BRANCH
pending
REVISION DETAIL
https://phabricator.kde.org/D7274
AFFECTED FILES
CMa
apol added inline comments.
INLINE COMMENTS
> ConfigureChecks.cmake:106
>Falling back to Fake backend")
> -set (KAUTH_BACKEND "FAKE")
> +#set (KAUTH_BACKEND "FAKE")
> endif (NOT PolkitQt5-1_FOUND)
Is this change required?
> ConfigureCheck
vkrause added a comment.
ping?
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D7274
To: vkrause, #frameworks, cordlandwehr
vkrause added a task: T6716: Fix native kauth-policy-gen build for KAuth.
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D7274
To: vkrause, #frameworks, cordlandwehr
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This is primarily useful for cross-compilation, where e.g. with Yocto
neither Qt5Widgets nor PolicyKit are easily available for the host build.
REPOSITORY
R283 KAuth
BRANCH
pending
REVISI
