This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bcdbe62660a9: Remove busy loop check in
TransferJobPrivate::slotDataReqFromDevice (authored by aacid).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7045?vs=18097&id=1
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
OK, thanks for the test.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid, dfaure
Cc: dfaure, apol, #frameworks
aacid added a comment.
In https://phabricator.kde.org/D7045#134216, @dfaure wrote:
> Yes that would be a good idea. AFAICS it's still one good reason to loop
around, i.e. it's a possible regression from this patch.
Seems TransferJobPrivate::slotIODeviceClosed takes care of reading
aacid updated this revision to Diff 18097.
aacid added a comment.
Added new test
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7045?vs=17514&id=18097
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7045
AFFECTED FILES
autotests/jobtest.cpp
dfaure added a comment.
Yes that would be a good idea. AFAICS it's still one good reason to loop
around, i.e. it's a possible regression from this patch.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid
Cc: dfaure, apol, #frameworks
aacid added a comment.
If you read the code (and the test that was failing once i changed the code),
no i don't think it is about that.
Do you want me to add a unit test for that scenario?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid
Cc: dfaure, a
dfaure added a comment.
isn't this about the case where there is more data available than
MAX_READ_BUF_SIZE, so we didn't read it all and we need to loop around to read
the rest?
OK, that's not what the if says, but I think that's still one case where we
need to loop. So maybe it should be
apol added a comment.
+1
I confirm KDE Connect still works through the QNAM abstraction without going
crazy calling `slotDataReqFromDevice`.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid
Cc: apol, #frameworks
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We don't need to call ourselves every time to see if the data transfer
finished,
the iodevice will signal us thorough readChannelFinished wh
