This revision was automatically updated to reflect the committed changes.
Closed by commit R246:ab4e46f45e84: Allow to build Sonnet without Qt5Widgets
(authored by vkrause).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6990?vs=17513&id=17595
REVISION DETAIL
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
BRANCH
sonnet-no-widget
REVISION DETAIL
https://phabricator.kde.org/D6990
To: vkrause, #frameworks, cordlandwehr, aacid
Cc: aacid
vkrause updated this revision to Diff 17513.
vkrause added a comment.
Add explicit option to disable the widget dependency.
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6990?vs=17379&id=17513
BRANCH
sonnet-no-widget
REVISION DETAIL
https://phabricato
aacid added a comment.
In https://phabricator.kde.org/D6990#130490, @vkrause wrote:
> Any preferences on the naming? [KF5|]_[NO|USE]_[WIDGETS|GUI|...]? I'm leaning towards the _USE_ variant, on by
default obviously, to avoid double negative conditions in the code.
No strong opinio
vkrause added a comment.
Any preferences on the naming? [KF5|]_[NO|USE]_[WIDGETS|GUI|...]? I'm leaning towards the _USE_ variant, on by
default obviously, to avoid double negative conditions in the code.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D6990
To: vkraus
vkrause added a comment.
Fair point, I'll add options for this.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D6990
To: vkrause, #frameworks, cordlandwehr
Cc: aacid
aacid added a comment.
I would really prefer if the option-ability of Widgets was enabled by a
setting or something, we really want to avoid people not having widgets
installed and getting a subpar build unless they really really ask for it
REPOSITORY
R246 Sonnet
REVISION DETAIL
https:/
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This is useful for cross-compilation, where we only need the QtCore-only
parsetrigrams build tool on the host and avoids having to pull in a full
graphics stack for the host build in Yocto.
R
