rjvbb added a comment.
Seems I found a crasher:
https://bugs.kde.org/show_bug.cgi?id=385398
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: rjvbb, dfaure, cullmann, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:878797830dbd: Switch from QtScript to QtQml (authored by
carewolf).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6914?vs=18072&id=18073#toc
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UP
carewolf updated this revision to Diff 18072.
carewolf added a comment.
Minor cleanups
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17281&id=18072
REVISION DETAIL
https://phabricator.kde.org/D6914
AFFECTED FILES
CMakeLists.txt
autotests/CMakeLists.txt
autotests/s
dhaumann added a comment.
As you wish, but we'd also be fine with this commit now, and additional
commits for fine tuning. The main point is to get this in as early as possible
to have a longer testing period.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde
carewolf added a comment.
Actually I wanted to clean a few minor things first. I will update it.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: dfaure, cullmann, #frameworks
dhaumann added a comment.
@carewolf Shall we commit and push this for you?
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: dfaure, cullmann, #frameworks
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Ok, cool, then please commit this Allen ;=)
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc
dfaure added a comment.
I cherry-pick fixes into a local branch, when needed. So there's no reason to
wait. It's always summer in master.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: dfaure, cul
dhaumann added a comment.
David just did his tagging work yesterday for KDE Frameworks 5.37:
https://mail.kde.org/pipermail/release-team/2017-August/010528.html
That means the git shas are fixed for the next release, except if some
show-stopper bug in a module forces us to pick another git
cullmann added a comment.
I think we should merge that after the next frameworks release it out and
clean the final bits up afterwards.
Thanks a lot for the contribution!
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dh
carewolf updated this revision to Diff 17281.
carewolf edited the summary of this revision.
carewolf added a comment.
Fixed ruby tests
REPOSITORY
R252 Framework Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17224&id=17281
REVISION DETAIL
https://phabricator
cullmann added a comment.
For me only the ruby tests fail, too.
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: cullmann, #frameworks
carewolf updated this revision to Diff 17224.
carewolf edited the summary of this revision.
carewolf added a comment.
Forgot to add the new private headers.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17223&id=17224
REVISION DETAIL
https://phabricator.kde.org/D6914
AFF
carewolf updated this revision to Diff 17223.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17209&id=17223
REVISION DETAIL
https://phabricator.kde.org/D6914
AFFECTED FILES
CMakeLists.txt
autotests/CMakeLists.txt
autotests/src/bug313759.cpp
autotests/src/bug317111.cpp
carewolf added a comment.
As I said it has some instrumentation and dead-code. I will clean it up a
bit. I was just hoping for a bit of help on why the ruby indent tests are being
weird.
INLINE COMMENTS
> dhaumann wrote in katescripthelpers.cpp:178
> Is this all not required anymore?
It is
dhaumann added a comment.
First of all, I also think this is a good patch.
There are some parts with debug output, some parts with warnings (e.g.
Q_FUNC_INFO), I guess this is temporary? :-)
Besides that, there are several parts with commented out code - is that work
in progress, or is
carewolf added a comment.
Note all of the helper functions are now single argument, but no script we
have use more. It doesn't however remove templating in the i18n functions.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann,
cullmann added a comment.
A private not-installed header is fine for that, sure.
I just would minimize the public API changes.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: cullmann, #frameworks
carewolf added a comment.
Actually the Q_GADGET part is not needed. I have commented out the code that
registers the qmetaobject, so at this point those changes are no longer needed.
I needed to do manual conversion anyway. The conversion functions doesn't need
to be in public headers. But t
cullmann added reviewers: cullmann, dhaumann, Frameworks.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: cullmann, #frameworks
cullmann added a comment.
First: As already said in person: COOL ;=)
I failed to port some years ago and just dumped my patch on the attic.
For the changes: Do we need the helper functions in the public headers? I see
that we need to make the things Q_GADGETs, thats fine, but do we need
carewolf created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Replaces the QtScript depedency with QtQml.
WIP: The ruby indentation test doesn't work, and appears unstable as
most fai
22 matches
Mail list logo
