vkrause closed this revision.
vkrause added a comment.
Pushed to master.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6867
To: vkrause, dhaumann, vonreth
Cc: #frameworks
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6867
To: vkrause, dhaumann, vonreth
Cc: #frameworks
vkrause updated this revision to Diff 17103.
vkrause added a comment.
Right, license is due to the original file.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6867?vs=17094&id=17103
REVISION DETAIL
https://phabricator.kde.org/D6867
AFFECTE
dhaumann added a comment.
Ah, and we need spellChecking="0" almost everywhere except for HereString and
String, and comments right?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6867
To: vkrause, dhaumann, vonreth
Cc: #frameworks
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
Looks almost good, but I think another iteration would be nice.
I assume we cannot relicense to MIT?
INLINE COMMENTS
> powershell.xml:5
> + version="1"
> + kateversion=
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Based on https://github.com/jgm/highlighting-kate/pull/80/ with some fixes
and improvements.
REPOSITORY
R216 Syntax Highlighting
REVISIO
