D6857: Improve apidox of openFile()

2017-07-23 Thread Elvis Angelaccio
elvisangelaccio marked an inline comment as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6857 To: elvisangelaccio, dfaure Cc: #frameworks

D6857: Improve apidox of openFile()

2017-07-23 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R306:5ac4fab4e5de: Improve apidox of openFile() (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6857?vs=17071&id=17073#toc REPOSITORY R306 KParts CHANGES SINCE LAST

D6857: Improve apidox of openFile()

2017-07-23 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > readonlypart.h:253 > + * If this method returns true, the part emits completed(), > + * otherwise emits canceled(). > + * otherwise += it REPOSITORY R306

D6857: Improve apidox of openFile()

2017-07-23 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add a note about the signals emitted depending on its return value. REPOSITORY R306 KParts BRANCH improve-apidox REVISION DETA