D6833: Add support for PrivilegeExecution in KIO jobs

2018-01-10 Thread David Faure
dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2018-01-02 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 24599. chinmoyr added a comment. 1.Made privilege execution default in BatchRenameJob. 2.Removed all occurences of PrivilegeExecution as job argument. With these changes and the latest changes in https://phabricator.kde.org/D6831 all the existing u

D6833: Add support for PrivilegeExecution in KIO jobs

2017-10-08 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 20489. chinmoyr added a comment. - Privilege execution turned on by default With these changes 3 tests of jobtest failed. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6833?vs=19178&id=20489 BRANCH master REVISION DETAIL https://phab

D6833: Add support for PrivilegeExecution in KIO jobs

2017-09-09 Thread David Faure
dfaure accepted this revision. REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-09-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 19178. chinmoyr added a comment. - Made method const - Removed unnecessary new line CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6833?vs=18019&id=19178 REVISION DETAIL https://phabricator.kde.org/D6833 AFFECTED FILES src/core/chmodjob.

D6833: Add support for PrivilegeExecution in KIO jobs

2017-08-11 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks OK to me now (just minor things) INLINE COMMENTS > copyjob.cpp:267 > > +KIO::JobFlag privilegeExecFlag() { return m_privilegeExecutionEnabled ? > PrivilegeExecution : DefaultFl

D6833: Add support for PrivilegeExecution in KIO jobs

2017-08-11 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 18019. chinmoyr added a comment. - Add PrivilegeExecution flag to subjobs - Removed the default case from CopyJob - Initially I didn't add checks for PrivilegeExecution flag in SimpleJob as most of them don't take it as argument. Now added checks for

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-27 Thread David Faure
dfaure added a comment. Ah, well, if the flag is completely unused in subjobs then yes sure, just remove the code that adds it. REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-27 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > chinmoyr wrote in copyjob.cpp:1674 > Ideally it should be set when m_privilegeExecutionEnabled is true. But it > will add more lines. Even though its just 2-3

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-26 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1674 > Should the flag always be set here? Or only if m_privilegeExecutionEnabled is > true? Ideally it should be set when m_privilegeExecutionEnabled is true. But it will add more lines. Even though its just 2-3 lin

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-26 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 17225. chinmoyr added a comment. - Remove extra if statements - if..else -> switch..case in CopyJob CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6833?vs=17022&id=17225 BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6833 AFFE

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-24 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > chmodjob.cpp:238 > KIO::SimpleJob *job = KIO::chmod(info.url, info.permissions); > +if (m_privilegeExecutionEnabled) { > +job->setParentJob(q); Maybe all these if()s can be removed? I assume setParentJob just stores a

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. chinmoyr added reviewers: dfaure, Frameworks. chinmoyr added a dependency: D6832: Integrate new file ioslave in KIO job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds support for PrivilegeExecution job flag in chmodjob, copyjob, deletejob, mkpathjob, transferjob and storedtransferjob. Dolp