kfunk added inline comments.
INLINE COMMENTS
> ktimecombobox.cpp:33
> +public:
> +KTimeValidator(QString timeFormat, QObject *parent = Q_NULLPTR);
> +KTimeValidator(QString timeFormat, QTime min, QTime max, QObject *parent
> = Q_NULLPTR);
Here and below: `nullptr` can be used directly i
cfeck requested changes to this revision.
cfeck added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ktimecombobox.cpp:33
> +public:
> +KTimeValidator(QString timeFormat, QObject *parent = Q_NULLPTR);
> +KTimeValidator(QString timeFormat, QTime min, QTim
cfeck added a comment.
Are you sure the patch is complete? I remember there was code which was
supposed to be replaced by the new validator.
INLINE COMMENTS
> ktimecombobox.cpp:608
> #include "moc_ktimecombobox.cpp"
> +#include "ktimecombobox.moc"
This does not look right.
REPOSITORY
R2
bednar updated this revision to Diff 17452.
bednar added a comment.
Ran through uncrustify.
Found a regression in my patch : colon (":") wouldn't be shown anymore, as it
is dependent on the input mask. So I left the input mask, and the QValidator
works in addition to the input mask.
REPOSI
cfeck added a comment.
Several code style issues. Please run it through uncrustify-kf5.cfg (see
kde-dev-scripts.git)
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6820
To: bednar
Cc: cfeck, #frameworks
bednar created this revision.
bednar added a project: Frameworks.
REVISION SUMMARY
Seeing the "TODO" in KTimeComboBoxPrivate::timeFormatToInputMask, I decided
to try and replace the input mask with a QValidator approach (as seen in
KDatePicker).
This is a first iteration to see if there is i
