jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
Looks good to me. If you can also remove this property from the TODO list
that would be great.
Btw. there is the same property missing in IPv6Setting in case you would like
to do t
pvillani edited reviewers, added: lvsouza; removed: Frameworks.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6687
To: pvillani, jgrulich, lvsouza
Cc: #frameworks
pvillani added a reviewer: Frameworks.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6687
To: pvillani, jgrulich, #frameworks
Cc: #frameworks
pvillani added a comment.
Sorry if something are missing, its my first pull request, let me know if any
change are needed. I've tested and it's working fine.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6687
To: pvillani, jgrulich
Cc: #frameworks
pvillani created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6687
AFFECTED FILES
autotests/settings/ipv4settingtest.cpp
src/settings
