This revision was automatically updated to reflect the committed changes.
fvogt marked an inline comment as done.
Closed by commit R242:48a8245db4d8: Treat Button/ToolButton labels as plaintext
(authored by fvogt).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6679
To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff,
fvogt marked an inline comment as done.
fvogt added inline comments.
INLINE COMMENTS
> broulik wrote in ToolButtonStyle.qml:100
> `Text.StyledText`
I think the priority queue in my brain is somehow backwards
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde
fvogt updated this revision to Diff 16649.
fvogt added a comment.
Fix typo in ToolButtonStyle
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6679?vs=16648&id=16649
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6679
AFF
broulik added a comment.
+1
(for others reading this: Explicitly turning it into `StyledText` prevents
Qt's `AutoText` from deciding to use `PlainText` in some cases which will then
again look broken. Note that `StyledText` uses a basic string parser so it's
nowhere near as heavy as `Ri
fvogt created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The label text gets treated as RichText/StyledText, which is required
to display mnemonics underlined. Therefore it is necessary to ma
