This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ca40063c4e49: do not crash qaccessible by causing a
resize in a resize event (authored by sitter).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6624?vs=16502&id=16860#toc
REPOSITORY
R236 K
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
Would be nice if you also commit the conditional in the KCharSelectItemModel
::setColumnCount.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
sitter added a comment.
In https://phabricator.kde.org/D6624#126506, @cfeck wrote:
> Let's say someone fixes the referenced Qt bug, and we are at a point
requiring that Qt version anyway. Are you going to remove the workaround?
Anyone who happens to stumble upon it can.
REPOSITOR
cfeck added a comment.
Let's say someone fixes the referenced Qt bug, and we are at a point
requiring that Qt version anyway. Are you going to remove the workaround?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfeck, anthonyf
sitter added a comment.
In https://phabricator.kde.org/D6624#126503, @cfeck wrote:
> If you are sure that your fix is "correct", then please remove the comment.
From reading it, it looks like a workaround for a Qt bug.
It is a workaround. It crashes because the life time of the qa
cfeck added a comment.
Reading your comment it is also wrong. Resizing the model does not cause a
resize of the widget. The widget size is controlled by the layout manager.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfeck, a
cfeck added a comment.
If you are sure that your fix is "correct", then please remove the comment.
From readiong it, it looks like a workaround for a Qt bug.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfeck, anthonyfieroni,
sitter added a comment.
In https://phabricator.kde.org/D6624#126465, @cfeck wrote:
> > It probably does.
>
> Were you able to test? I would prefer the simpler patch. I cannot test it,
because my system does not have accessibility enabled.
Yes, I did not manage to crash it that
cfeck added a comment.
> It probably does.
Were you able to test? I would prefer the simpler patch. I cannot test it,
because my system does not have accessibility enabled.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfe
gladhorn added a comment.
Considering that the Qt bug will not be fixed in the next few days (I hope to
get around to it, but it's involved), this makes sense.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfeck, anthonyfieroni
sitter added a comment.
In https://phabricator.kde.org/D6624#124077, @cfeck wrote:
> Reading your description on the referenced QTBUG, does it help to use a
compare with previous m_columns in KCharSelectItemModel ::setColumnCount()
before doing the emit dance?
It probably does. T
cfeck added a comment.
Reading your description on the referenced QTBUG, does it help to use a
compare with previous m_columns in KCharSelectItemModel ::setColumnCount()
before doing the emit dance?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: si
sitter added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kcharselect.cpp:251
> QSignalBlocker blockResize(this) ?
Block inhibits signal emission/slot calling. That is not what we want. We want
the signals to run, just not on the same call chain as the resize event.
REPOSITORY
anthonyfieroni added inline comments.
INLINE COMMENTS
> kcharselect.cpp:251
> +connect(timer, &QTimer::timeout, [&,timer]() {
> +d->_k_resizeCells();
> +timer->deleteLater();
QSignalBlocker blockResize(this) ?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
h
sitter added a comment.
FWIW, this is a bit of workaround. Not having kcharselect crash for just
about every search is well worth it though.
Also, I am not sure I particularly like the qtimer code. It does beat having
to pass `const char *` method names to `invokeMethod` and turning the pri
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When enabling accessibility qaccessible will automatically add a11y support
constructs to core qt types such as qtableview.
Unfortunately
16 matches
Mail list logo
