D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-20 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:e4c90bf90717: [client] Track all created ConnectionThreads and add API to access them (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6569?

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-13 Thread Martin Flöser
graesslin updated this revision to Diff 16660. graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Make this compile. Looks like kdevelop fooled me and compiled KWin instead of KWayland (that happens all the time to me) REPOSITORY R127

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-09 Thread Martin Flöser
graesslin updated this revision to Diff 16406. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Use mutex to protect the potentially shared data structure REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH all-connection-threads REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin, davidedmundson Cc: davidedmundson, dfaure, plasma-de

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-09 Thread Martin Flöser
graesslin added a comment. @davidedmundson if you have another idea how to tackle the problem I'm absolutely open to it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin Cc: davidedmundson, dfaure, plasma-devel, ZrenBo

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6569#123081, @davidedmundson wrote: > I don't think this is necessary. > > The only times we want need to delete the connection ourselves is when client code is creating it via ConnectionThread::fromApplication. If they creat

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread David Edmundson
davidedmundson added a comment. I don't think this is necessary. The only times we want need to delete the connection ourselves is when client code is creating it via ConnectionThread::fromApplication. If they create it themselves, we don't want to, and there's no need to track it.

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread Martin Flöser
graesslin added a dependent revision: D6571: Delete all Wayland connections by plugins prior to own Wayland connection. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin Cc: dfaure, plasma-devel, ZrenBot, progwolff, lesliez

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread David Faure
dfaure added a comment. Isn't a mutex needed to protect this data structure that is apparently modified by different threads? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin Cc: dfaure, plasma-devel, ZrenBot, progwolf

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is change needed by KWin. KWin has the problem that it destroys its internal Wayland connection (KWin as client