This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface
(authored by asturmlechner).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6493?vs=16896&id=
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, davidedmundson, #frameworks, Zren
asturmlechner updated this revision to Diff 16896.
asturmlechner added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Changed according to review
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https
davidedmundson added a comment.
Edit: I was wrong.
We do need your first change but not the second change to cmakelists.txt
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma
Cc: davidedmundson, #frameworks
asturmlechner abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma
Cc: davidedmundson, #frameworks
davidedmundson added a comment.
You're right that there's a bug, but I think this solution has backwards.
We don't use WindowSystem in public API, and it's PlasmaQuick/CmakeLists.txt
that's wrong by putting it in public not the other way round.
See https://phabricator.kde.org/D6495
asturmlechner added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma
Cc: #frameworks
asturmlechner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Otherwise, reverse-dependencies are bugged
with finding KF5WindowSystem themselves.
TEST PLAN
Builds fine, plasma-sdk does not nee
