D6492: Also use m_currentRequest when checking for installed and updates

apol closed this revision. apol added a comment. Submitted https://commits.kde.org/knewstuff/8d94a0cd28dc4897535197a363193c914f59a9ad REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6492 To: apol, #frameworks, leinir

D6492: Also use m_currentRequest when checking for installed and updates

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Different approach, but yeah, telling people what'll actually happen works :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 To: apol, #fr

D6492: Also use m_currentRequest when checking for installed and updates

apol updated this revision to Diff 16178. apol added a comment. Fix doc REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6492?vs=16176&id=16178 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 AFFECTED FILES src/core/engine.h To: ap

D6492: Also use m_currentRequest when checking for installed and updates

apol updated this revision to Diff 16176. apol added a comment. Just document stuff REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6492?vs=16173&id=16176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 AFFECTED FILES src/core/engi

D6492: Also use m_currentRequest when checking for installed and updates

apol updated this revision to Diff 16173. apol added a comment. Oops REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6492?vs=16172&id=16173 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 AFFECTED FILES src/core/engine.cpp src/co

D6492: Also use m_currentRequest when checking for installed and updates

apol updated this revision to Diff 16172. apol added a comment. Improve documentation and consistency REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6492?vs=16150&id=16172 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 AFFECTED FIL

D6492: Also use m_currentRequest when checking for installed and updates

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. derp, not accepted, my bad... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6492 To: apol, #frameworks, leinir

D6492: Also use m_currentRequest when checking for installed and updates

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That is indeed a very good point. I think we might possibly have an issue here, though, in that since these two searches are no longer stand-alone, if the filter is not explicitly reset bef

D6492: Also use m_currentRequest when checking for installed and updates

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Otherwise if requestMoreData is called, we query the wrong request which can be quite big if it happens before it's initialized REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL http