This revision was automatically updated to reflect the committed changes.
Closed by commit R304:28833ae05d00: Extend unittests to test stable sort.
(authored by adridg).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6049?vs=15016&id=15530
REVISION DETAIL
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Sorting correctness (and more thorough testing) is good, yes. LGTM! :)
As to the missing arcconfig... will need someone to produce one of those who
actually uses arc to fix that ;) Remo
adridg added reviewers: whiting, Frameworks.
adridg added a comment.
(also, this repo has a .reviewboardrc but no .arcconfig)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6049
To: adridg, whiting, #frameworks
Cc: #frameworks
adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- Helper function constructs a permutation of the list of menu-items that
need to be sorted, then sorts and tests.
- Test ten permutations
