This revision was automatically updated to reflect the committed changes.
Closed by commit R304:4b37ece102dd: Expand KNewStuff documentation (authored by
leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5902?vs=15908&id=15924
REVISION DETAIL
https:
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> leinir wrote in README.md:35
> It still need to be found before you can set it as runtime (unless i am
> fundamentally misunderstanding something of course) - like how it's
leinir added inline comments.
INLINE COMMENTS
> apol wrote in README.md:35
> Still it shouldn't be looked-for, should it?
It still need to be found before you can set it as runtime (unless i am
fundamentally misunderstanding something of course) - like how it's done in
Discover... or am i misu
apol added a comment.
General +1
INLINE COMMENTS
> leinir wrote in README.md:35
> No, you are quite right - i don't think it is even technically possible in
> most cases, so this will need some reworking to explain that (it's a Qt Quick
> module, after all)
Still it shouldn't be looked-for
leinir updated this revision to Diff 15908.
leinir added a comment.
Add/fix a whole bunch of more documentation, identified as missing (or
incorrect) by Aniketh
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5902?vs=14660&id=15908
REVISION DETAIL
http
leinir updated this revision to Diff 14660.
leinir marked 2 inline comments as done.
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5902?vs=14634&id=14660
REVISION DETAIL
https://phabricator.kde.org/D5902
AFFECTED FILES
README.md
src/core/engine.h
s
leinir marked 2 inline comments as done.
leinir added inline comments.
INLINE COMMENTS
> apol wrote in README.md:30
> I'd say that it looks better to have `CONFIG` rather than `NO_MODULE`. Both
> should work.
>
> Also `find_package(KF5 COMPONENTS NewStuffCore)` reads better to my eye.
It certa
apol added inline comments.
INLINE COMMENTS
> README.md:30
> +
> +find_package(KF5NewStuffCore NO_MODULE) # for the KNewStuffCore library
> only
> +find_package(KF5NewStuff NO_MODULE) # for the KNewStuff UI library, will
> pull in KNewStuffCore for you
I'd say that it looks better to h
leinir created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add mention of KNewStuffCore and KNewStuffQuick to the base documentation,
and expand the API documentation to mention some of the new functi
leinir added a reviewer: KNewStuff.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D5902
To: leinir, #knewstuff
Cc: #frameworks
10 matches
Mail list logo
